----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review110101 -----------------------------------------------------------
Let's get some Windows team reviews on this. let's try and use snake_case in stout. 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 17 - 18) <https://reviews.apache.org/r/39019/#comment169882> alphabetize. 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 26) <https://reviews.apache.org/r/39019/#comment169883> brace on new line. 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 53 - 55) <https://reviews.apache.org/r/39019/#comment169884> As Joseph mentioned, this `NOTE:` is not necessary. 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 81) <https://reviews.apache.org/r/39019/#comment169885> `directory == NULL` 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 89) <https://reviews.apache.org/r/39019/#comment169886> `directory->d_name == NULL` 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 198 - 200) <https://reviews.apache.org/r/39019/#comment169888> Where does the internal data for DIR get freed? - Joris Van Remoortere On Nov. 17, 2015, 7:06 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39019/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 7:06 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3441 > https://issues.apache.org/jira/browse/MESOS-3441 > > > Repository: mesos > > > Description > ------- > > Windows: Added dirent compat code for non-Unix systems. > > > Diffs > ----- > > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 1a7037d64afeedc340258c92067e95d1d3caa027 > > Diff: https://reviews.apache.org/r/39019/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
