> On Dec. 14, 2015, 3:05 p.m., Qian Zhang wrote: > > src/master/validation.cpp, line 331 > > <https://reviews.apache.org/r/41306/diff/1/?file=1161530#file1161530line331> > > > > So now we allow a task has both ExecutorInfo and CommandInfo, right? If > > so, then you may need to update the following comments for TaskInfo as well. > > /** > > * ... Either ExecutorInfo or CommandInfo should be set. > > * ... > > */ > > message TaskInfo { > > ... > > } > > > > However, I still prefer the old way: either ExecutorInfo or CommandInfo > > should be set rather than both. So I think in `Master::_accept()` you can > > separate `validateExecutorInfo()` from `validation::task::validate()`, and > > call it separately before adding command executor into command task.
Yes, we used to add a new object into `ExecutorInfo::task_command` for task and keep this validation; but the validation seems not necessry after discussing with Vinode. Anyway, I think this's an option discussion for this JIRA. @Vinode/@Joseph, any comments on this? - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41306/#review110172 ----------------------------------------------------------- On Dec. 12, 2015, 5:55 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41306/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2015, 5:55 p.m.) > > > Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian > Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-1718 > https://issues.apache.org/jira/browse/MESOS-1718 > > > Repository: mesos > > > Description > ------- > > MESOS-1718: use command line executor to launch tasks > > > Diffs > ----- > > src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 > src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c > src/slave/slave.cpp 9bd86e122c070cd072a54d4de8097f844bd95bb0 > > Diff: https://reviews.apache.org/r/41306/diff/ > > > Testing > ------- > > > Thanks, > > Klaus Ma > >
