----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/#review110321 -----------------------------------------------------------
Ship it! Ship It! - Joris Van Remoortere On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39623/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 9:13 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > CMake: Added protobuf compilation to Windows builds. > > > Diffs > ----- > > src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 > > Diff: https://reviews.apache.org/r/39623/diff/ > > > Testing > ------- > > `make check` from CMake on OS X 10.10. > `make check` from Autotools on OS X 10.10. > Ran `check` project in VS on Windows 10. > > PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH > into my Ubuntu box to test this from Ubuntu > > > Thanks, > > Alex Clemmer > >