> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary? Or should I > reword to stay under the limit? > > Kevin Klues wrote: > I meant 50 character limit
I think that the commit summary do not have such limit. Please check https://reviews.apache.org/dashboard/?group=mesos&view=to-group to view all of the patches and there is actually no limit, but no limit does not mean it can be very long ;-) - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110353 ----------------------------------------------------------- On Dec. 15, 2015, 12:44 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41364/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 12:44 a.m.) > > > Review request for mesos, Benjamin Hindman and Neil Conway. > > > Bugs: MESOS-3844 > https://issues.apache.org/jira/browse/MESOS-3844 > > > Repository: mesos > > > Description > ------- > > The current instructions assume you are launching mesos on your local > machine. This could be confusing for someone trying to run mesos on > (e.g. AWS) and not understanding why they can't access the mesos > web page. This note adds a comment to try and hinder such confusion. > > > Diffs > ----- > > docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb > > Diff: https://reviews.apache.org/r/41364/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >