----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/#review110924 -----------------------------------------------------------
Thanks! A few wording suggestions, and a clarification of 'visibility' scoping, but otherwise shippable. include/mesos/mesos.proto (line 1564) <https://reviews.apache.org/r/41187/#comment170918> "Port number on which the framework exposes a service." include/mesos/mesos.proto (line 1566) <https://reviews.apache.org/r/41187/#comment170919> "Name of the service hosted on this port." include/mesos/mesos.proto (line 1568) <https://reviews.apache.org/r/41187/#comment170916> s/frameworks/framework/ And technically, you've got a dangling preposition. Grammar nazis would demand "protocol on which the framework exposes its services". include/mesos/mesos.proto (lines 1570 - 1571) <https://reviews.apache.org/r/41187/#comment170920> The visibility setting for a Port overrides the general visibility setting in the DiscoveryInfo. include/mesos/mesos.proto (line 1573) <https://reviews.apache.org/r/41187/#comment170917> s/tags that could be/metadata to be/ since you shouldn't decorate the message unless you have a consumer in mind, plus 'metadata' is more "meta". Also, you probably don't need to quote "decorate". - Adam B On Dec. 16, 2015, 7:07 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41187/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 7:07 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Bugs: MESOS-3962 > https://issues.apache.org/jira/browse/MESOS-3962 > > > Repository: mesos > > > Description > ------- > > Adding labels field to Port information, for service discovery to associate > arbitrary tags by applications to ports for a given task. > > > Diffs > ----- > > include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 > include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 > > Diff: https://reviews.apache.org/r/41187/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Avinash sridharan > >