----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/#review111333 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/message.proto (line 72) <https://reviews.apache.org/r/40944/#comment171467> I think we should make this optional as well, since technically we don't really require this. src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 79) <https://reviews.apache.org/r/40944/#comment171465> Formatting seems a bit odd, Can you do: Try<JSON..> v1Compat = JSON::parse<JSON::Object>( stringify(manife....); src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 87) <https://reviews.apache.org/r/40944/#comment171466> Shouldn't this fit in the same line? - Timothy Chen On Dec. 9, 2015, 6:36 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40944/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 6:36 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Fixed protobuf parse failure when pulling a docker image. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/message.proto > 824a788af0d2c779a2ca82a69ba65b6361154038 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 89f61c20e52e5eff8d8e92748f03b3b461516cd2 > src/slave/containerizer/mesos/provisioner/docker/spec.cpp > 1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e > src/tests/containerizer/provisioner_docker_tests.cpp > c63bf53fee40ef12536a16e11f4d5224c4e4278e > > Diff: https://reviews.apache.org/r/40944/diff/ > > > Testing > ------- > > make check(ubuntu14.04 + clang3.6) > > > Thanks, > > Gilbert Song > >
