> On Dec. 20, 2015, 3:01 p.m., Benjamin Hindman wrote: > > This looks fine, assuming that we actually need `CreateContainerLogger` > > (see below). > > Benjamin Hindman wrote: > I looked ahead in the review chain and it doesn't look like you ever > extend `CreateContainerLogger`, so why was it necessary? Why couldn't you > just call `ContainerLogger::create`?
Removed the test helper from the review chain. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41169/#review111428 ----------------------------------------------------------- On Dec. 21, 2015, 11:37 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41169/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2015, 11:37 a.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4088 > https://issues.apache.org/jira/browse/MESOS-4088 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/containerizer/filesystem_isolator_tests.cpp > f1dd81bbf4bb42aebd6295e15973b7438bc9f9e7 > src/tests/containerizer/mesos_containerizer_tests.cpp > fe679354d04d68b68e168cd8c4eab23898f6532f > > Diff: https://reviews.apache.org/r/41169/diff/ > > > Testing > ------- > > make (OSX, Centos7, Ubuntu 14, Debian 8) > make check (OSX, Centos7, Ubuntu 14, Debian 8) > sudo bin/mesos-tests.sh (Centos7, Ubuntu 14, Debian 8) > > > Thanks, > > Joseph Wu > >
