----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review112231 -----------------------------------------------------------
src/slave/container_loggers/rotate.cpp (line 115) <https://reviews.apache.org/r/41783/#comment172588> Are you expecting termination sent as a empty pipe from stdin here? src/slave/container_loggers/rotate.cpp (line 125) <https://reviews.apache.org/r/41783/#comment172589> I think maxFiles shouldn't be zero as well right? We will then not remove the oldest log file. - Timothy Chen On Dec. 29, 2015, 10:18 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41783/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 10:18 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4136 > https://issues.apache.org/jira/browse/MESOS-4136 > > > Repository: mesos > > > Description > ------- > > Adds a non-default ContainerLogger that constrains total log size by rotating > logs (i.e. renaming the head log file). > > > Diffs > ----- > > src/slave/container_loggers/rotate.cpp PRE-CREATION > src/slave/container_loggers/rotating.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41783/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
