----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41806/#review112350 -----------------------------------------------------------
Patch looks great! Reviews applied: [41806] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Dec. 30, 2015, 9:53 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41806/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2015, 9:53 p.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos > > > Description > ------- > > Used `AWAIT_EXPECT_RESPONSE_HEADER_EQ()` to check the "Content-Type" of > the response, rather than accessing the "headers" field directly, and > used the symbol `APPLICATION_JSON` rather than a string literal. Also > added "Content-Type" checks to a few places that had neglected to make > them, and cleaned up some whitespace style. > > > Diffs > ----- > > src/tests/executor_http_api_tests.cpp > 8d86df5fd54bcfe998eb7dc4302509e7a00e9d84 > src/tests/fault_tolerance_tests.cpp > ba657d0e1d8515cffd1b37925bf91a84b2feaef1 > src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 > src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 > src/tests/monitor_tests.cpp a848d14ebb6cab79c06bcf55bd39f044b41a006e > src/tests/repair_tests.cpp 63ec889c4954c2c60d3466952551aa25b3284ddf > src/tests/scheduler_driver_tests.cpp > 1365d21ccad87923b862fb4942f1fd51630a62b7 > src/tests/scheduler_http_api_tests.cpp > 4d23a5a8368e0ed126469fa4a90a889b339ad004 > src/tests/slave_tests.cpp 328c853a338145256dadfc9364b9c2a0e6c356cb > src/tests/status_update_manager_tests.cpp > bd34b97a3559a5fea9a7a253a89e0ac3029f4a33 > src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b > > Diff: https://reviews.apache.org/r/41806/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >