> On 一月 4, 2016, 7:19 a.m., Guangya Liu wrote: > > It is suggested to use past tone for the Summary and please also add a > > period to the end of the Summary. > > Guangya Liu wrote: > Please also update other patches for phase 1 to follow the above style.
You can refer to https://reviews.apache.org/r/41584/ for more guidance of commit message. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41850/#review112508 ----------------------------------------------------------- On 一月 3, 2016, 2:31 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41850/ > ----------------------------------------------------------- > > (Updated 一月 3, 2016, 2:31 a.m.) > > > Review request for mesos and Guangya Liu. > > > Bugs: MESOS-3892 > https://issues.apache.org/jira/browse/MESOS-3892 > > > Repository: mesos > > > Description > ------- > > Before getting evictable executors for evicting, it need to trace which > execuotor can be evicted. > > > Diffs > ----- > > src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c > src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c > > Diff: https://reviews.apache.org/r/41850/diff/ > > > Testing > ------- > > > Thanks, > > Klaus Ma > >
