----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41872/#review112633 -----------------------------------------------------------
Patch looks great! Reviews applied: [41872] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 4, 2016, 12:48 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41872/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 12:48 p.m.) > > > Review request for mesos, Alexander Rojas, Michael Park, and Till Toenshoff. > > > Bugs: MESOS-4272 > https://issues.apache.org/jira/browse/MESOS-4272 > > > Repository: mesos > > > Description > ------- > > yIn the IEEE floating point standard representation usually only values > where the fractional part of the normalized form is a multiple of 2^n > can be represented exactly; a value of 0.33 cannot be represented > exactly. This can lead to an incorrectly failing tests where the > calculated value does not match the expectation. > > Instead switch to a value of 0.25 which can be represented exactly. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp > 0aafc8643cf6afcb58befa6c1e7d427ac529be03 > > Diff: https://reviews.apache.org/r/41872/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Bannier > >
