----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41548/#review112884 -----------------------------------------------------------
src/master/master.hpp (lines 1009 - 1010) <https://reviews.apache.org/r/41548/#comment173362> Snake case?! src/master/quota_handler.cpp (line 341) <https://reviews.apache.org/r/41548/#comment173360> This is rather confusing to me. Above we created a convenience reference to `create.get()` named `quotaInfo`. Now you are mutating that `create.get()` result directly. How about making `quotaInfo` above a copy (instead of a reference) and then modifying that one here, if needed? src/master/quota_handler.cpp (lines 524 - 525) <https://reviews.apache.org/r/41548/#comment173361> No snake case here please! - Till Toenshoff On Jan. 5, 2016, 11:16 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41548/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 11:16 a.m.) > > > Review request for mesos, Alexander Rukletsov and Till Toenshoff. > > > Bugs: MESOS-4081 > https://issues.apache.org/jira/browse/MESOS-4081 > > > Repository: mesos > > > Description > ------- > > Quota Authorization: Implemented quota remove authorization. > > > Diffs > ----- > > include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed > src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9 > src/master/quota_handler.cpp 1d84ef5767b3cb7cf870dd184aa2d9f030919498 > > Diff: https://reviews.apache.org/r/41548/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
