----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41945/#review112952 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On Jan. 5, 2016, 9:23 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41945/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 9:23 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, and Joris Van > Remoortere. > > > Bugs: MESOS-4059 > https://issues.apache.org/jira/browse/MESOS-4059 > > > Repository: mesos > > > Description > ------- > > There were three inverse offer updates in the test body, but only two > `FUTURE_DISPATCH` expectations on `updateInverseOffer`. This patch adds the > missing `FUTURE_DISPATCH` after the first inverse offer update. > > Prior to this change, the first `FUTURE_DISPATCH` was expected to correspond > to the second inverse offer. In some cases, the first inverse offer would > trigger the expectation instead (and/or the test would reach the > `Clock::settle()` prior to one of the `Call` 's reaching the master). > > > Diffs > ----- > > src/tests/master_maintenance_tests.cpp > 2ca1e878254ec411220226e5d0ed48d6ae54a0db > > Diff: https://reviews.apache.org/r/41945/diff/ > > > Testing > ------- > > make check (OSX & Centos7) > > # Run 8 instances of `openssl speed` somewhere else on the computer. > # Then: > bin/mesos-test.sh --gtest_filter="*InverseOffersFilters*" --gtest_repeat=5000 > --gtest_break_on_failure > > > Thanks, > > Joseph Wu > >
