> On Dec. 28, 2015, 5:33 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp, lines 21-22 > > <https://reviews.apache.org/r/41461/diff/5/?file=1174022#file1174022line21> > > > > Do you want to reference MESOS-3993? Maybe update the ticket as well, > > once this lands.
Done. I think we'll probably turn MESOS-3993 into a more general, "switch back to `std::result_of`" > On Dec. 28, 2015, 5:33 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp, lines 33-34 > > <https://reviews.apache.org/r/41461/diff/5/?file=1174022#file1174022line33> > > > > Let's make a note that `std::invoke()`, which is c++17 AFAIK, is > > supported by msvc 2015 and it's not in <functional>. Done. ``` // `std::invoke` is a C++17 feature, but we only compile this code for Windows, // which has it implemented in VS 2015 Update 1. It is also supposed to be // defined in `<functional>`, but is included in `<utility>` in VS. ``` > On Dec. 28, 2015, 5:33 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp, line 41 > > <https://reviews.apache.org/r/41461/diff/5/?file=1174022#file1174022line41> > > > > `int` is dummy here, right? Mind writing a comment about it? I changed it to using the `Prefer`, and `LessPrefer` which already exists in `<process/future.hpp>`. Left a comment to factor these out later. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41461/#review111984 ----------------------------------------------------------- On Jan. 6, 2016, 12:55 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41461/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 12:55 a.m.) > > > Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van > Remoortere. > > > Bugs: MESOS-4220 > https://issues.apache.org/jira/browse/MESOS-4220 > > > Repository: mesos > > > Description > ------- > > VS 2015 won't support C++14 `std::result_of` SFINAE until Update 2, so > `result_of` must be replaced with `decltype(invoke)`. > > Here, we implement SFINAE `result_of` in `stout`. > > Follow-up from [r40114](https://reviews.apache.org/r/40114/). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe > 3rdparty/libprocess/3rdparty/stout/include/stout/result_of.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41461/diff/ > > > Testing > ------- > > `make check` on OS X, compiled on Windows. > > > Thanks, > > Michael Park > >
