----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41550/#review113050 -----------------------------------------------------------
src/tests/master_quota_tests.cpp (line 1216) <https://reviews.apache.org/r/41550/#comment173549> s/acl/acl1 src/tests/master_quota_tests.cpp (lines 1239 - 1241) <https://reviews.apache.org/r/41550/#comment173550> This comment is related to the whole block and not to `Resources` struct only. Let's split it into two parts: one for the block and one for resources. src/tests/master_quota_tests.cpp (lines 1257 - 1259) <https://reviews.apache.org/r/41550/#comment173552> Same here. src/tests/master_quota_tests.cpp (lines 1291 - 1294) <https://reviews.apache.org/r/41550/#comment173553> Also here, and below. Since each block is actually a test case, we should prepend it with a comment explaining the intention behind, same as we do for each test. src/tests/master_quota_tests.cpp (lines 1206 - 1207) <https://reviews.apache.org/r/41550/#comment173555> Now you also check that unauthorized princiapls can't do that. Please update the comment (and maybe the test name) accordingly (e.g. `AuthorizeQuotaRequests`). src/tests/master_quota_tests.cpp (line 1329) <https://reviews.apache.org/r/41550/#comment173556> To be consistent with the previous test, let's s/AuthorizedQuotaRequestsWithoutPrincipal/AuthorizeQuotaRequestsWithoutPrincipal src/tests/master_quota_tests.cpp (lines 1336 - 1342) <https://reviews.apache.org/r/41550/#comment173557> Blank lines, please. src/tests/master_quota_tests.cpp (lines 1352 - 1364) <https://reviews.apache.org/r/41550/#comment173558> We agreed to wrap those in blocks, no? Same for remove quota below. - Alexander Rukletsov On Jan. 6, 2016, 10:53 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41550/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 10:53 a.m.) > > > Review request for mesos, Alexander Rukletsov and Till Toenshoff. > > > Bugs: MESOS-4083 > https://issues.apache.org/jira/browse/MESOS-4083 > > > Repository: mesos > > > Description > ------- > > Quota Authorization: Added tests for quota removal authorization. > > > Diffs > ----- > > src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 > src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c > > Diff: https://reviews.apache.org/r/41550/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
