> On Jan. 5, 2016, 1:08 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, line 359 > > <https://reviews.apache.org/r/41943/diff/2/?file=1182252#file1182252line359> > > > > Can you also check that the parsed JSON (protobuf object) is equivalent > > to parsing the same JSON with the `null` field removed? > > > > i.e. > > ``` > > protobuf::parse<tests::Foo>( > > "{" > > " \"burger\": \"big\" > > "}"); > > ``` > > > > Same for below.
I'll go ahead and drop this, since you no longer have that test. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41943/#review112927 ----------------------------------------------------------- On Jan. 6, 2016, 6:07 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41943/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 6:07 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van > Remoortere, Joseph Wu, and Timothy Chen. > > > Bugs: MESOS-4294 > https://issues.apache.org/jira/browse/MESOS-4294 > > > Repository: mesos > > > Description > ------- > > Fixed stout protobuf::parse to support parsing JSON object containing > JSON::Null. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 98ea47794b3a7c99b3cbd2418ba6e36eb5951259 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp > bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h > 08793c9d21d4b9b7dd3081cfa35afa47a7e0d28a > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc > 797b3b000f3c3fea42cabc3b40baf7235eab6b1e > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto > 4c11e23f875b75bcb9d5c65ee66d55b6f72e546d > > Diff: https://reviews.apache.org/r/41943/diff/ > > > Testing > ------- > > make check (tested on both ubuntu14.04 and OSX10.10) > > > Thanks, > > Gilbert Song > >
