> On 一月 6, 2016, 12:01 p.m., Klaus Ma wrote: > > Overall comments is that: is this code called by any others? If not, why > > should we add that? I'd suggest to add this on demand. > > Joseph Wu wrote: > I agree. If this is not used, we should not add it.
It is needed as the master need to make sure task and its executor do not run on different resources. They must run on same kind of resources, either non-revocable resources, usage slack resources or allocation slack resources. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/#review113053 ----------------------------------------------------------- On 一月 2, 2016, 1:15 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41333/ > ----------------------------------------------------------- > > (Updated 一月 2, 2016, 1:15 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, and Klaus Ma. > > > Bugs: MESOS-4146 > https://issues.apache.org/jira/browse/MESOS-4146 > > > Repository: mesos > > > Description > ------- > > Added helper functions to filter usage slack resources. This helper function > will be used to validate if the task is using usage slack resource or not so > as to make sure that one task or executor can only use same kind of resources. > > > Diffs > ----- > > include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d > include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa > src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 > src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 > src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 > > Diff: https://reviews.apache.org/r/41333/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
