> On Jan. 8, 2016, 4:36 p.m., Jian Qiu wrote: > > src/slave/slave.cpp, line 3967 > > <https://reviews.apache.org/r/41857/diff/3/?file=1187189#file1187189line3967> > > > > this check may not be necessary because resources cannot be negative?
Yes; it won't be negative, but it'll return first resources instead of empty. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41857/#review113430 ----------------------------------------------------------- On Jan. 8, 2016, 2:54 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41857/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 2:54 p.m.) > > > Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris > Van Remoortere, Joseph Wu, and Jian Qiu. > > > Bugs: MESOS-3892 > https://issues.apache.org/jira/browse/MESOS-3892 > > > Repository: mesos > > > Description > ------- > > get evictable executors > > > Diffs > ----- > > src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c > src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f > > Diff: https://reviews.apache.org/r/41857/diff/ > > > Testing > ------- > > > Thanks, > > Klaus Ma > >
