> On Jan. 7, 2016, 4:12 p.m., Benjamin Hindman wrote: > > src/tests/container_logger_tests.cpp, lines 28-30 > > <https://reviews.apache.org/r/41781/diff/2/?file=1181460#file1181460line28> > > > > How come these aren't pulled out since they are three levels?
Looks like we're a bit inconsistent. I'll fix this here and submit a separate set of patches to tweak this in other places. https://reviews.apache.org/r/42082/ https://reviews.apache.org/r/42083/ https://reviews.apache.org/r/42084/ - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41781/#review113369 ----------------------------------------------------------- On Jan. 8, 2016, 12:06 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41781/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 12:06 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4136 > https://issues.apache.org/jira/browse/MESOS-4136 > > > Repository: mesos > > > Description > ------- > > This test loads a non-default ContainerLogger module that rotates logs (i.e. > renaming the head log file) and constrains total log size. > > > Diffs > ----- > > src/tests/container_logger_tests.cpp > c6b2e597517c74a55649287dc5ae5a3115f9a640 > > Diff: https://reviews.apache.org/r/41781/diff/ > > > Testing > ------- > > This test is run later in the review chain. > > > Thanks, > > Joseph Wu > >
