> On Jan. 7, 2016, 10:32 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [40975] > > > > Failed command: ./support/apply-review.sh -n -r 40975 > > > > Error: > > 2016-01-07 18:32:55 URL:https://reviews.apache.org/r/40975/diff/raw/ > > [1164/1164] -> "40975.patch" [1] > > No files to lint > > > > Error: Commit message summary (the first line) must end in a period. > > James Peach wrote: > I don't know how to fix this. The subject is correct in the commit I am > pushing; I don't know how to convince the tooling of that.
`support/post-reviews.sh` doesn't overwrite the review board "Summary" (so if you've added the period there, ReviewBot will still complain). You can just edit the field on the web UI. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/#review113286 ----------------------------------------------------------- On Jan. 8, 2016, 12:58 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40975/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 12:58 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Document that libprocess ignores SIGPIPE. > > > Diffs > ----- > > 3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3 > > Diff: https://reviews.apache.org/r/40975/diff/ > > > Testing > ------- > > None. > > > Thanks, > > James Peach > >
