----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41649/#review114097 -----------------------------------------------------------
Ship it! Looks great! Only a handful of minor doc/comment changes. I'll make these myself and commit it. src/internal/devolve.cpp <https://reviews.apache.org/r/41649/#comment174892> s/v1:;/v1::/ docs/configuration.md (line 1444) <https://reviews.apache.org/r/41649/#comment174890> Not yours, but where is the opening `(`? I'd suggest s/upgrade!)./upgrade./ docs/configuration.md (line 1445) <https://reviews.apache.org/r/41649/#comment174889> Can remove this paragraph break now. docs/configuration.md (line 1454) <https://reviews.apache.org/r/41649/#comment174904> Not yours, but s/alloted/allotted/ docs/configuration.md (line 1457) <https://reviews.apache.org/r/41649/#comment174891> Remove this paragraph break docs/slave-recovery.md (line 16) <https://reviews.apache.org/r/41649/#comment174905> Your parenthesized pluralities are awkward and the parenthesized subject doesn't match the parenthesized verb. To correct this, I would recommend rewording as follows: s/the framework(s) enable(s)/a framework enables/ - Adam B On Jan. 12, 2016, 7:01 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41649/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 7:01 a.m.) > > > Review request for mesos, Adam B, Joerg Schad, and Till Toenshoff. > > > Bugs: MESOS-2317 > https://issues.apache.org/jira/browse/MESOS-2317 > > > Repository: mesos > > > Description > ------- > > Removed slave checkpointing logic after deprecation cycle. > > > Diffs > ----- > > docs/configuration.md cbe7f5a338a0fc350c4b6c0e2f1f48bd0869ac34 > docs/slave-recovery.md 73b837278f928511b17d9dbf30286f7b1eb4ce29 > include/mesos/mesos.proto 74e9d00d6826adfb7fd2433c3deced6d2ca51e98 > src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba > src/examples/docker_no_executor_framework.cpp > 7b3f0581f75105addb388dc15c4a0390ae4e0e0e > src/examples/java/TestFramework.java > cbcdeedb0da22f82e274d088eb15a4128fd920fe > src/examples/python/test_framework.py > 6af6d22f54c0ad702917d09cf658e70f7032d793 > src/master/allocator/mesos/hierarchical.hpp > 86ea5a402ed67f8f22f11d5730147cd907d66a08 > src/master/allocator/mesos/hierarchical.cpp > df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > src/master/master.cpp 5268408fc63a28afabc27cba96d3ecb360608a65 > src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 > src/slave/containerizer/containerizer.hpp > 6964d136818ea9904fa35cd778eb9ef19e2c64fc > src/slave/flags.cpp 19c2996c4572b992030f8824380f3979ced7e526 > src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f > src/slave/state.cpp b912c554fc9cb5593f541a7803422c22dc03dffd > src/tests/master_authorization_tests.cpp > 3e14f63604b93a7f4ad9cb2b916747d958056559 > src/tests/slave_recovery_tests.cpp c0e4ff75b35c9e806741aab5696771e66d2c2ea8 > src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6 > > Diff: https://reviews.apache.org/r/41649/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
