----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41816/#review114233 -----------------------------------------------------------
Ship it! src/slave/containerizer/mesos/containerizer.cpp (line 688) <https://reviews.apache.org/r/41816/#comment175044> Not this time. We typically try to make the each commits atomic. In this case, I would probably get 'directory' and 'user' from 'containerConfig' and pass them to the isolator. - Jie Yu On Jan. 8, 2016, 6:17 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41816/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 6:17 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4240 > https://issues.apache.org/jira/browse/MESOS-4240 > > > Repository: mesos > > > Description > ------- > > Generated ContainerConfig in mesos containerizer. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 89d18624b08f2c953b9fa21663aeda694d4aac12 > src/slave/containerizer/mesos/containerizer.cpp > f3c370aeb331beb6202fd30cd0278877da0b42e0 > > Diff: https://reviews.apache.org/r/41816/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
