----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/#review114257 -----------------------------------------------------------
Ship it! LGTM! Just consider whether or not we should put it as `https.hpp` under `schemes` directory. - Gilbert Song On Jan. 12, 2016, 10:22 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42236/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 10:22 p.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and > Timothy Chen. > > > Bugs: MESOS-4296 > https://issues.apache.org/jira/browse/MESOS-4296 > > > Repository: mesos > > > Description > ------- > > Added a utility function to create https URI. > > > Diffs > ----- > > src/uri/schemes/http.hpp 84a80b91ee664c29eed69f94d505aad45be326cf > > Diff: https://reviews.apache.org/r/42236/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
