----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/#review114394 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 677) <https://reviews.apache.org/r/41791/#comment175231> It should be `newStatelessReserved.contains(total)`; in `contains`, it'll return false if any resource did not contain. src/master/allocator/mesos/hierarchical.cpp (lines 732 - 737) <https://reviews.apache.org/r/41791/#comment175252> Update the comments to list cases, for example: 1. if new `reserved.stateless` > old, pala... 2. if new ... <, pala... - if xxx - if xxx - Klaus Ma On Jan. 13, 2016, 8:58 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41791/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 8:58 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4145 > https://issues.apache.org/jira/browse/MESOS-4145 > > > Repository: mesos > > > Description > ------- > > Update allocation slack resources if reserve some > new stateless reserved resources. For such case, > the allocation slack resources will be increased. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > d541bfa3f4190865c65d35c9d1ffdb8a3f194056 > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/41791/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
