> On Jan. 14, 2016, 11:05 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 88 > > <https://reviews.apache.org/r/42047/diff/3/?file=1189507#file1189507line88> > > > > Do you still need `_containerId` here?
Removed _containerId . Thanks. > On Jan. 14, 2016, 11:05 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 96 > > <https://reviews.apache.org/r/42047/diff/3/?file=1189507#file1189507line96> > > > > Can we use Owned<Info> here? Storing the Info objects directly in the Hashmap. The only catch here is that since the only field in 'struct Info' is a const string the copy assignment operator is implicitly deteled. This is not a problem since we can use emplace when initializing a key,value in the hashmap. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42047/#review114588 ----------------------------------------------------------- On Jan. 15, 2016, 5:44 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42047/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 5:44 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4262 > https://issues.apache.org/jira/browse/MESOS-4262 > > > Repository: mesos > > > Description > ------- > > Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to > isolate a mesos container using the net_cls cgroup subsystem. > > > Diffs > ----- > > src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 > src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/42047/diff/ > > > Testing > ------- > > > Thanks, > > Avinash sridharan > >
