> On Jan. 15, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 166-169 > > <https://reviews.apache.org/r/39803/diff/10/?file=1197869#file1197869line166> > > > > Is this supposed to return `int` like the ones below? or are they > > supposed to return `bool`? > > Alex Clemmer wrote: > Good catch, they are originally macros, but the expression they return is > `bool`, so let's use that. > > Now that I think about it, let's also remove `S_ISLNK` because we can't > test for that using only `mode`, and anyway, we don't need it in Mesos except > for the POSIX version of stat.hpp. > > Michael Park wrote: > Right, so the first few macros are an expression of type `bool` but the > last few are expressions of type `int`. I wasn't sure if we rely on that > being an `int` `0` anywhere. That is, can we just change `S_ISBLK` to be > `bool S_ISBLK(const int mode) { return false; }`? > > Alex Clemmer wrote: > That appears to be right.
Oh, `S_ISLNK` is actually used in files.hpp. Let's follow up by porting that in the files.hpp review. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review114644 ----------------------------------------------------------- On Jan. 15, 2016, 1:58 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39803/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 1:58 a.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Implemented stout/os/stat.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > ec851dcb08d938defeb6066810011e003d594b29 > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > PRE-CREATION > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/symlink.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp > ffe074830ef90f492990bf695e686c885b9a155c > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/stat.hpp > 5b38b9af654d7d1c574f0cc573083b66693ced1d > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 27edf1b4f8647a2720f2962eafa110d694b3baed > > Diff: https://reviews.apache.org/r/39803/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
