> On Jan. 13, 2016, 8:39 p.m., Klaus Ma wrote: > > @Joseph/Vinod, would you help to review those patches move executor from > > slave to master? > > Joseph Wu wrote: > There are still several open issues open on each prior review. Can you > go through and make sure those are addressed? > > Klaus Ma wrote: > Honestly, I'd like you to help review the code diff about executor's > resources: where should get command line executor's resources? cut from tasks > or add additional resources to it.
@Joseph, the patches are rebased and commnets are addressed :). Would you help to reivew it? - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41308/#review114191 ----------------------------------------------------------- On Jan. 18, 2016, 10:19 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41308/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 10:19 p.m.) > > > Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian > Downes, Joris Van Remoortere, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-1718 > https://issues.apache.org/jira/browse/MESOS-1718 > > > Repository: mesos > > > Description > ------- > > MESOS-1718: Unit Test for moving getExecutorInfo from slave to master > > > Diffs > ----- > > src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 > src/tests/containerizer/docker_containerizer_tests.cpp > a1a44daae68e5a4c6961e13ee9e16207c5d54768 > src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 > src/tests/fetcher_cache_tests.cpp 1fb1e213d3c35479789688d1a3a49a3c6058b198 > src/tests/master_tests.cpp aa0e0d8087175e3a3ed5b63a23d31aa6fe00d1b3 > src/tests/master_validation_tests.cpp > 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5 > src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9 > src/tests/oversubscription_tests.cpp > 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a > src/tests/reservation_endpoints_tests.cpp > b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 > src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 > src/tests/slave_tests.cpp 7fe566770bbd802111885de061a53a3edf914840 > > Diff: https://reviews.apache.org/r/41308/diff/ > > > Testing > ------- > > > Thanks, > > Klaus Ma > >