> On Dec. 28, 2015, 11:31 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 347 > > <https://reviews.apache.org/r/41459/diff/1/?file=1166978#file1166978line347> > > > > Other similar constructs will be converted when the code using them > > will compile on Windows. > > Michael Park wrote: > Sorry, I don't think I understand what this means. Could you > elaborate/clarify?
Synced with Daniel offline. This was meant to be a note that this transformation will need to be applied in other places in the codebase such as `slave.cpp`. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41459/#review112086 ----------------------------------------------------------- On Jan. 5, 2016, 11:58 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41459/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 11:58 p.m.) > > > Review request for mesos, Benjamin Hindman, Alex Clemmer, and Joris Van > Remoortere. > > > Bugs: MESOS-4221 > https://issues.apache.org/jira/browse/MESOS-4221 > > > Repository: mesos > > > Description > ------- > > VS 2015 won't support C++14 `std::function` SFINAE until Update 2, so > converting `_Deferred` to `std::function` must be done by explicitly calling > `_Deferred`'s conversion function. > > Follow-up from [r40114](https://reviews.apache.org/r/40114/). > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > bcb5668565298825056f1b48d48efe12d2e56e7c > > Diff: https://reviews.apache.org/r/41459/diff/ > > > Testing > ------- > > `make check` on OS X, compiled on Windows. > > > Thanks, > > Michael Park > >
