> On Jan. 18, 2016, 11:02 p.m., Timothy Chen wrote: > > src/tests/uri_fetcher_tests.cpp, line 216 > > <https://reviews.apache.org/r/42239/diff/5/?file=1199886#file1199886line216> > > > > Should we create a constant for docker registry server url? We're > > referring to it in multiple places and I think we could then update it if > > Docker decides to change it.
Created a constant, and added a TODO to expose it. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review115074 ----------------------------------------------------------- On Jan. 21, 2016, 12:41 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42239/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2016, 12:41 a.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and > Timothy Chen. > > > Bugs: MESOS-4296 > https://issues.apache.org/jira/browse/MESOS-4296 > > > Repository: mesos > > > Description > ------- > > Added tests for the Docker URI fetcher plugin. > > > Diffs > ----- > > src/tests/uri_fetcher_tests.cpp c3bc4eaa26edf2c4e827341794b230d022a91283 > > Diff: https://reviews.apache.org/r/42239/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >