----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42615/ -----------------------------------------------------------
Review request for mesos. Repository: mesos Description ------- For example, avoid using `std::string` in a .cpp file that already does `using std::string`. Diffs ----- src/authentication/http/basic_authenticator_factory.cpp 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682 src/cli/execute.cpp 0add77558e07ff49f0134ddb9085509501c61aab src/common/http.cpp b7e71eb79ccb8ef1d0bbd168d77d4d4591ecb09b src/common/protobuf_utils.cpp 53324ab569751924f25290641d1a70da790c2104 src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e src/examples/balloon_framework.cpp 3c17676c92f72d41c501b2435a7017e3c9f01278 src/examples/test_container_logger_module.cpp 6b1f4dbd63145afe4de17830c0a2a6202a896be7 src/examples/test_http_authenticator_module.cpp acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906 src/examples/test_qos_controller_module.cpp f8aa1d730f6cdf5ab3f11789e9699682cc08ddd5 src/files/files.cpp dd64976ca454786152a8e29f590e8c1ed1df3b54 src/health-check/main.cpp 0beaed575ec865d81e6e3d83d8a0c894613acba4 src/hook/manager.cpp 6ee93038dce1247cffbc82c736a1c7a1ecb84bb0 src/launcher/fetcher.cpp 902e927ce0cbcf70e41041375e61987752629957 src/linux/routing/queueing/fq_codel.cpp d840e383f28481ba58d8269217a8a194c4e87db5 src/linux/routing/queueing/ingress.cpp c25a93966caca5c5a9eef91e6caa5d9e29091bee src/linux/systemd.cpp d3f4a63d833a5bc599494e925d709ba0cc70d9ec src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f src/log/tool/initialize.cpp c9706d1e33659f7b0e375419197b207cb96d4ca9 src/log/tool/read.cpp 9abf5a82338c554920283e0329cd83e4c787c103 src/log/tool/replica.cpp 8baf79755da420cf594d706f31aa561b5d665051 src/master/allocator/sorter/drf/sorter.cpp 3a442f121f3a1505513877a5c78458a4b8d0a824 src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae src/master/maintenance.cpp df7cd6ca5a097611e5ca5a46cc988ef636da096b src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38 src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0 src/slave/containerizer/fetcher.cpp 4ac9149980cf7f013b318218a1b29369c5dcff17 src/slave/containerizer/mesos/linux_launcher.cpp 61801fffe9bac1a995a57d8b4e8c004d624bbd63 src/slave/containerizer/mesos/provisioner/docker/paths.cpp 9c5c24992f9ea36159271691cca0147851240088 src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp b74c760e90b12f5bf45b6e626e2b661f841e5a8d src/slave/containerizer/mesos/provisioner/docker/store.cpp 03425daaf015cf231920b7eda1d5424895a41286 src/slave/qos_controllers/load.cpp 52520d6220784423c09001b8bd59e090ebf787ec src/slave/state.cpp fae7738a1cb7168abc0cfe35b075bbc73306b820 src/tests/attributes_tests.cpp 3f3dde1301566f279c3fc7dc24e3ef67039a4c14 src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 src/tests/containerizer/cgroups_isolator_tests.cpp 0d24809701c42dc036bbd051791545f4742d1e9a src/tests/containerizer/external_containerizer_test.cpp da52860f4a1d5363d7b61b9a8bb6abad02d89736 src/tests/containerizer/provisioner_docker_tests.cpp 33df60065903228749833bbad20449ba8784594a src/tests/credentials_tests.cpp 6e3725c61a55a2c1d183ee278cf3d72be16a6e40 src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e src/tests/gc_tests.cpp ef5544b627ac4a9f9c13fe13b0c51b21d5b98a12 src/tests/hierarchical_allocator_tests.cpp 953712149bd951789beb29c72779c4ac65aa48dc src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 src/tests/http_authentication_tests.cpp bd622576973648e0dfeae1453a5ce631e4171352 src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 src/tests/monitor_tests.cpp 2226458b59b4a279a92e1353bd61457a0018d2a9 src/tests/registrar_tests.cpp 58b3fccf5450d20032c5c6d20d76dbd868c424a3 src/tests/registrar_zookeeper_tests.cpp 3861dcf8341bfa520f94fd244b4814827299b861 src/tests/scheduler_driver_tests.cpp f35c4957b08803dba924ebf1a5f0af9daac9d0c5 src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead src/tests/values_tests.cpp a4eb68ad13407f471a07a9a923ed31c7890da9f7 src/watcher/whitelist_watcher.cpp 14d7de751884d4734942e315e61a94c29868ff4b src/zookeeper/detector.cpp a3d68c12e3800805a35f9bb05e7689830eedbae6 Diff: https://reviews.apache.org/r/42615/diff/ Testing ------- "make check" on OSX and Arch Linux. Thanks, Neil Conway
