> On Jan. 22, 2016, 8:19 a.m., Ben Mahler wrote: > > Hm.. do you think batch is a better term than periodic? I'm not so sure.
I actually think "periodic" is a better name, while "batch" is more an implementation detail. However, we use "batch" in the allocator and some other tests, while "periodic" is mentioned only in this file. I would propose to change it to "batch" for consistency now, and consider a better name later if we feel it's important. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42636/#review115808 ----------------------------------------------------------- On Jan. 22, 2016, 1:24 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42636/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 1:24 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 953712149bd951789beb29c72779c4ac65aa48dc > > Diff: https://reviews.apache.org/r/42636/diff/ > > > Testing > ------- > > None > > > Thanks, > > Alexander Rukletsov > >