----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42677/#review115965 -----------------------------------------------------------
Fix it, then Ship it! support/verify_reviews.py (line 145) <https://reviews.apache.org/r/42677/#comment177000> Can we use `os.path.join` so that we don't run into issues if for some reason `os.environ['BUILD_URL']` doesn't end with a slash? ``` os.path.join(os.environ['BUILD_URL'], 'console') ``` - Michael Park On Jan. 23, 2016, 12:39 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42677/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2016, 12:39 a.m.) > > > Review request for mesos, Ben Mahler and Michael Park. > > > Bugs: MESOS-4478 > https://issues.apache.org/jira/browse/MESOS-4478 > > > Repository: mesos > > > Description > ------- > > Truncated the size of review that ReviewBot can post to 1 MB to avoid > overloading the ASF ReviewBoard server. > > > Diffs > ----- > > support/verify_reviews.py 39661d7ee914ef3c48a2974bd309d2531209e7ea > > Diff: https://reviews.apache.org/r/42677/diff/ > > > Testing > ------- > > Tested locally with dummy arguments. > > ? mesos git:(vinod/reviewbot_tail_output) > BUILD_URL=https://builds.apache.org/job/mesos-reviewbot/10980/ > ./support/verify_reviews.py vinod kone 1 > git rev-parse HEAD > Checking if review: 42474 needs verification > Skipping blocking review 42474 > Checking if review: 42503 needs verification > Skipping blocking review 42503 > Checking if review: 42590 needs verification > Latest diff timestamp: 2016-01-22 03:29:36 > Latest dependency change timestamp: 2016-01-22 03:37:52 > Verifying review 42590 > Dependent review: https://reviews.apache.org/api/review-requests/40529/ > Dependent review: https://reviews.apache.org/api/review-requests/42547/ > Dependent review: https://reviews.apache.org/api/review-requests/41333/ > Dependent review: https://reviews.apache.org/api/review-requests/41334/ > Dependent review: https://reviews.apache.org/api/review-requests/40375/ > Applying review 40375 > ./support/apply-review.sh -n -r 40375 > Applying review 41334 > ./support/apply-review.sh -n -r 41334 > Applying review 41333 > ./support/apply-review.sh -n -r 41333 > Applying review 42547 > ./support/apply-review.sh -n -r 42547 > Applying review 40529 > ./support/apply-review.sh -n -r 40529 > Applying review 42590 > ./support/apply-review.sh -n -r 42590 > export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; > ./support/docker_build.sh > Posting review: Bad patch! > > Reviews applied: [40375, 41334, 41333, 42547, 40529, 42590] > > Failed command: export OS=ubuntu:14.04;export > CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh > > Error: > ...<truncated>... > + : ubuntu:14.04 > + : gcc > + : --verbose > +++ dirname ./support/docker_build.sh > ++ cd ./support/.. > ++ pwd > + MESOS_DIRECTORY=/Users/vinodkone/workspace/mesos > + cd /Users/vinodkone/workspace/mesos > + DOCKERFILE=Dockerfile > + rm -f Dockerfile > + case $OS in > + append_dockerfile 'FROM ubuntu:14.04' > + echo FROM ubuntu:14.04 > + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*' > + echo RUN rm -rf '/var/lib/apt/lists/*' > + append_dockerfile 'RUN apt-get update' > + echo RUN apt-get update > + append_dockerfile 'RUN apt-get -y install build-essential clang git maven > autoconf libtool' > + echo RUN apt-get -y install build-essential clang git maven autoconf libtool > + append_dockerfile 'RUN apt-get -y install openjdk-7-jdk python-dev > python-boto libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev > libev-dev' > + echo RUN apt-get -y install openjdk-7-jdk python-dev python-boto > libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev > + append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos' > + echo RUN adduser --disabled-password --gecos ''\'''\''' mesos > + append_dockerfile 'ENV GTEST_FILTER -FsTest.FileSystemTableRead' > + echo ENV GTEST_FILTER -FsTest.FileSystemTableRead > + append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml' > + echo ENV GTEST_OUTPUT xml:report.xml > + case $COMPILER in > + append_dockerfile 'ENV CC gcc' > + echo ENV CC gcc > + append_dockerfile 'ENV CXX g++' > + echo ENV CXX g++ > + append_dockerfile 'WORKDIR mesos' > + echo WORKDIR mesos > + append_dockerfile 'COPY . /mesos/' > + echo COPY . /mesos/ > + append_dockerfile 'RUN chown -R mesos /mesos' > + echo RUN chown -R mesos /mesos > + append_dockerfile 'USER mesos' > + echo USER mesos > + append_dockerfile 'CMD ./bootstrap && ./configure --verbose && > DISTCHECK_CONFIGURE_FLAGS="--verbose" GLOG_v=1 MESOS_VERBOSE=1 make -j8 > distcheck' > + echo CMD ./bootstrap '&&' ./configure --verbose '&&' > 'DISTCHECK_CONFIGURE_FLAGS="--verbose"' GLOG_v=1 MESOS_VERBOSE=1 make -j8 > distcheck > ++ date +%s > + TAG=mesos-1453508830-10633 > + docker build --no-cache=true -t mesos-1453508830-10633 . > ./support/docker_build.sh: line 117: docker: command not found > > Full log: https://builds.apache.org/job/mesos-reviewbot/10980/console > Error handling URL > https://reviews.apache.org/api/review-requests/42590/reviews/: UNAUTHORIZED > ({"stat": "fail", "err": {"msg": "The username or password was not correct", > "code": 104}}) > git clean -fd > git reset --hard c365743d459c2617a17ccc1b2bb3912ab9712e3c > > > Thanks, > > Vinod Kone > >