----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42683/#review115990 -----------------------------------------------------------
Fix it, then Ship it! src/tests/resources_tests.cpp (lines 1715 - 1741) <https://reviews.apache.org/r/42683/#comment177025> I don't think those are necessary. Can you just test resource equality and 'contains' for disk resources like you did below. PS: you already have TEST(DiskResourcesTest, DiskSourceEquals) src/tests/resources_tests.cpp (line 1830) <https://reviews.apache.org/r/42683/#comment177026> Kill this line - Jie Yu On Jan. 23, 2016, 10:52 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42683/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2016, 10:52 a.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666 > > Diff: https://reviews.apache.org/r/42683/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
