----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review116041 -----------------------------------------------------------
Fix it, then Ship it! I'll fix up the issue below and commit, thanks! src/slave/container_loggers/logrotate.cpp (line 107) <https://reviews.apache.org/r/41783/#comment177055> { on newline please. - Benjamin Hindman On Jan. 23, 2016, 9:07 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41783/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2016, 9:07 a.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4136 > https://issues.apache.org/jira/browse/MESOS-4136 > > > Repository: mesos > > > Description > ------- > > Adds a non-default ContainerLogger that constrains total log size by rotating > logs (i.e. renaming the head log file). > > > Diffs > ----- > > src/slave/container_loggers/lib_logrotate.hpp PRE-CREATION > src/slave/container_loggers/lib_logrotate.cpp PRE-CREATION > src/slave/container_loggers/logrotate.hpp PRE-CREATION > src/slave/container_loggers/logrotate.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41783/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
