> On Jan. 26, 2016, 2:14 a.m., Anand Mazumdar wrote: > > src/common/roles.cpp, line 62 > > <https://reviews.apache.org/r/42762/diff/1/?file=1220834#file1220834line62> > > > > Not yours: Can we remove the period at the end of each of the error > > messages? > > > > We dump them with the periods later: > > https://github.com/apache/mesos/blob/master/src/master/master.cpp#L635
Updated in the review after this one. Thanks for catching this. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42762/#review116256 ----------------------------------------------------------- On Jan. 26, 2016, 12:10 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42762/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 12:10 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > This validation is used inside resource math which in turn is used > heavily in the code base. > The temporary string allocations caused a significant performance > degradation in this critical path. > > > Diffs > ----- > > src/common/roles.cpp 5be807018ff84174cf0cabb933f6828d458d3846 > > Diff: https://reviews.apache.org/r/42762/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
