----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review116455 -----------------------------------------------------------
Fix it, then Ship it! Looking good. Just some minor things. src/executor/executor.cpp (lines 353 - 355) <https://reviews.apache.org/r/41283/#comment177475> Move this to #364. How about: // NOTE: We will be here if either subscribe or non-subscribe connection is disconnected. We explicitly // disconnect both the connections here for simplicity. src/executor/executor.cpp (line 430) <https://reviews.apache.org/r/41283/#comment177478> just do ``` // Ignore if this timeout is for a stale connection. if (connections != _connections) { return; } ``` to be consistent with what you did in `disconnected(()` - Vinod Kone On Jan. 26, 2016, 9:19 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41283/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 9:19 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-3550 > https://issues.apache.org/jira/browse/MESOS-3550 > > > Repository: mesos > > > Description > ------- > > This change introduces the implementation for the executor library. > > This uses the new HTTP Connection interface to ensure calls are properly > pipelined. > > `connected` -> Callback invoked when a TCP connection is established with the > agent for the Subscribe call. > `disconnected` -> When the Subscribe TCP connection is interrupted possibly > due to an agent restart. > `received` -> When the executor receives events from the agent upon > subscribing. > > > Diffs > ----- > > src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 > src/executor/executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41283/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
