> On Jan. 26, 2016, 9:18 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 196 > > <https://reviews.apache.org/r/42696/diff/1/?file=1218950#file1218950line196> > > > > Good idea, but then we need to set checkpointing to true for the > > recovery test below.
@bernd, thank you very much. Could you help review again? - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review116330 ----------------------------------------------------------- On Jan. 27, 2016, 3:04 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42696/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 3:04 a.m.) > > > Review request for mesos and Bernd Mathiske. > > > Bugs: MESOS-4486 > https://issues.apache.org/jira/browse/MESOS-4486 > > > Repository: mesos > > > Description > ------- > > Speed up FetcherCacheTest.Local* test cases. > > > Diffs > ----- > > src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e > > Diff: https://reviews.apache.org/r/42696/diff/ > > > Testing > ------- > > Before apply the patch: > ``` > $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*" > [ OK ] FetcherCacheTest.LocalUncached (2580 ms) > [ OK ] FetcherCacheTest.LocalCached (2524 ms) > [ OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms) > [ OK ] FetcherCacheTest.LocalCachedExtract (2551 ms) > ``` > > > After apply the patch: > ``` > $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*" > [ OK ] FetcherCacheTest.LocalUncached (873 ms) > [ OK ] FetcherCacheTest.LocalCached (1609 ms) > [ OK ] FetcherCacheTest.LocalUncachedExtract (926 ms) > [ OK ] FetcherCacheTest.LocalCachedExtract (1509 ms) > ``` > > Also test the recovery test manually: > > ``` > sudo ./bin/mesos-tests.sh > --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery" > ``` > > > Thanks, > > haosdent huang > >
