----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43014/#review117149 -----------------------------------------------------------
Fix it, then Ship it! src/common/command_utils.cpp (line 188) <https://reviews.apache.org/r/43014/#comment178239> This is problematic to me because 'cmd' will go out of scope (after sha512 returns). The captured reference here will become a dangling pointer. - Jie Yu On Jan. 30, 2016, 5:03 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43014/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2016, 5:03 p.m.) > > > Review request for mesos, Jie Yu, Jojy Varghese, and Vinod Kone. > > > Bugs: MESOS-4556 > https://issues.apache.org/jira/browse/MESOS-4556 > > > Repository: mesos > > > Description > ------- > > Fix ShasumTest.SHA512SimpleFile failed on centos7. > > > Diffs > ----- > > src/common/command_utils.cpp 722d0b42a995a6a5a6cfd08f3c356dabd1080cd1 > src/tests/common/command_utils_tests.cpp > e81c724fc28717f5cb1849d75a066b6da713cd44 > > Diff: https://reviews.apache.org/r/43014/diff/ > > > Testing > ------- > > # check in CentOS 7. > sudo ./bin/mesos-tests.sh --gtest_filter="ShasumTest.SHA512SimpleFile" > > > Thanks, > > haosdent huang > >
