----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42247/#review117165 -----------------------------------------------------------
Ship it! Ship It! - Till Toenshoff On Jan. 25, 2016, 2:35 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42247/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 2:35 p.m.) > > > Review request for mesos, Jan Schlicht and Till Toenshoff. > > > Bugs: MESOS-4329 > https://issues.apache.org/jira/browse/MESOS-4329 > > > Repository: mesos > > > Description > ------- > > Waiting for the launch result is not enough as it is unrelated to > whether the launched container has terminated. If we do not wait for > that the global teardown might find it still running and fail the tests > (this can happen if we e.g., execute this test in isolation). > > Also aline the name of the launch result to follow the canonical > scheme. > > > Diffs > ----- > > src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead > > Diff: https://reviews.apache.org/r/42247/diff/ > > > Testing > ------- > > make check (OS X 10.10.5) > > > Thanks, > > Benjamin Bannier > >
