----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review117168 -----------------------------------------------------------
src/docker/docker.cpp (lines 517 - 522) <https://reviews.apache.org/r/42516/#comment178252> The user network was introduced in docker 1.9, is it possible to add some error handlingn here to handle the case if end user is using docker version before 1.9? - Guangya Liu On 一月 27, 2016, 7:05 a.m., Ezra Silvera wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42516/ > ----------------------------------------------------------- > > (Updated 一月 27, 2016, 7:05 a.m.) > > > Review request for mesos and TimothyIL TimothyIL. > > > Bugs: MESOS-4369 > https://issues.apache.org/jira/browse/MESOS-4369 > > > Repository: mesos > > > Description > ------- > > Signed-off-by: Ezra Silvera <e...@il.ibm.com> > > > Diffs > ----- > > include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 > include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 > src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e > > Diff: https://reviews.apache.org/r/42516/diff/ > > > Testing > ------- > > Using Swarm running on Mesos create a network with "docker network create > --driver=bridge myNetwork" and then create a container on that network: > "docker run --net=myNetwork...." > > > Thanks, > > Ezra Silvera > >
