----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42993/#review117177 -----------------------------------------------------------
It is better add some unit tests in `hierarchical_allocator_tests.cpp` to cover the update in allocator for shareable resources. - Guangya Liu On 一月 30, 2016, 12:26 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42993/ > ----------------------------------------------------------- > > (Updated 一月 30, 2016, 12:26 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4431 > https://issues.apache.org/jira/browse/MESOS-4431 > > > Repository: mesos > > > Description > ------- > > The allocator tracks allocated shared resources separately from the > remaining allocated resources so that multiple frameworks see the > same view of the shared resource at any given time. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 1a07d69016407e5aad2209586da37fecbcddb765 > src/master/allocator/sorter/drf/sorter.hpp > 4669149b81de39b4bb921ef7cd6787aa583f6e40 > src/master/allocator/sorter/drf/sorter.cpp > db47d640e36c0302d7c6254a9c58caa878feac01 > src/master/allocator/sorter/sorter.hpp > a0a779b81f6d048271f15256b38ff907ae144b83 > src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83 > > Diff: https://reviews.apache.org/r/42993/diff/ > > > Testing > ------- > > make check done. > > > Thanks, > > Anindya Sinha > >
