> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 65-75 > > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line65> > > > > Why do we need this?
Was using this data structure to pass on the usage of handles for a given major handle. It was useful in unit-testing, but thought will be useful in implementing a usage interface to the NetClsHandleMgr class. Should I keep it? > On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 108-113 > > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line108> > > > > We do you need this in this patch? There are quite a few places where we are throwing erros and need to convert the major and minor handle into a hex string, hence thought implement this as a static function (maybe inline) . Should I keep this? > On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, line 40 > > <https://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line40> > > > > 2 blank lines above please. > > Guangya Liu wrote: > Does there are any policies for this when need one blank line and when > need two blank line? The coding guide lines give the following rule: "Elements outside classes (classes, structs, global functions, etc.) should be spaced apart by two empty lines." So from that perspective this makes sense. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117225 ----------------------------------------------------------- On Feb. 1, 2016, 2:20 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42586/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 2:20 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4345 > https://issues.apache.org/jira/browse/MESOS-4345 > > > Repository: mesos > > > Description > ------- > > This class will be responsible for keeping track of the free and allocated > net_cls handles. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > b4bc52114389d1c1efce2830f4292bd89bb0de7c > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > ddc1bf0939e5e8995e6f34fe7b8509b51704f63e > > Diff: https://reviews.apache.org/r/42586/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
