> On Feb. 2, 2016, 10:10 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 502 > > <https://reviews.apache.org/r/42843/diff/1/?file=1222482#file1222482line502> > > > > Looks like HttpProxy can send ServiceUnavailable too for some cases > > https://github.com/apache/mesos/blob/b8122f110f826e97f263b982f8fdd14ef53c24f6/3rdparty/libprocess/src/process.cpp#L1137 > > > > maybe CHECK isn't prudent here?
Aha, good catch. Let me discard this change. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42843/#review117497 ----------------------------------------------------------- On Feb. 2, 2016, 9:56 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42843/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 9:56 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4255 > https://issues.apache.org/jira/browse/MESOS-4255 > > > Repository: mesos > > > Description > ------- > > The agent does not return an `ServiceUnavailable` response for `Subscribe` > calls. Added a `CHECK` to ensure this in the executor library. > > > Diffs > ----- > > src/executor/executor.cpp 92334ffb8af83b1c86c44bd406147893c7c6daa3 > > Diff: https://reviews.apache.org/r/42843/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
