-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43136/#review117595
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (line 71)
<https://reviews.apache.org/r/43136/#comment178837>

    Do we also need fix similar ::clone syscall in routing_tests.cpp?
    ```
    TEST_F(RoutingVethTest, ROOT_LinkCreatePid)
    {
      // Stack used in the child process.
      unsigned long long stack[32];
    
      pid_t pid = ::clone(child, &stack[31], CLONE_NEWNET | SIGCHLD, NULL);
    ```


- haosdent huang


On Feb. 3, 2016, 8:27 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43136/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 8:27 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
>     https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> on AArch64 architecture stack 16-byte aligned mandatory,so in libprocess 
> achieve syscal "clone" must distinguish different cpus.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5a 
> 
> Diff: https://reviews.apache.org/r/43136/diff/
> 
> 
> Testing
> -------
> 
> test run ok in AArch64.
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Reply via email to