----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41288/#review117527 -----------------------------------------------------------
src/tests/mesos.hpp (line 839) <https://reviews.apache.org/r/41288/#comment178956> The naming here is a bit confusing. How about putting this class and the above in an executor namespace and do something like this: ``` namespace mesos { namespace internal { namespace tests { ... ... ... namespace executor { template<typename Event> class Callbacks { }; template <typename Mesos, typename Event> class TestMesos:: public Mesos { }; } ... ... ... } } } ``` One issue might be that someone might be confused between the top level MesosTest class and TestMesos class, but I think the namespace should alleviate the confusion. src/tests/mesos.hpp (line 850) <https://reviews.apache.org/r/41288/#comment178724> each argument should be on its own line when wrapping. put `lambda::_1` on the next line. src/tests/mesos.hpp (line 853) <https://reviews.apache.org/r/41288/#comment178733> why is this public? src/tests/mesos.hpp (line 863) <https://reviews.apache.org/r/41288/#comment178730> should this be an owned pointer? src/tests/mesos.hpp (line 869) <https://reviews.apache.org/r/41288/#comment178723> new line. - Vinod Kone On Jan. 19, 2016, 10:28 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41288/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 10:28 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-4433 > https://issues.apache.org/jira/browse/MESOS-4433 > > > Repository: mesos > > > Description > ------- > > This change introduces a versioned callback interface for testing HTTP based > executors. The reasoning is similar to `MESOS-3339` , the corresponding issue > for Schedulers. > > > Diffs > ----- > > src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac > > Diff: https://reviews.apache.org/r/41288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
