----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43149/#review117725 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp (line 2203) <https://reviews.apache.org/r/43149/#comment179003> `Try<size_t> count = numify<size_t>(...)` since the thread count is an uint? 3rdparty/libprocess/src/process.cpp (lines 2207 - 2208) <https://reviews.apache.org/r/43149/#comment179004> Since we do LOG(WARNING) instead of LOG(FATAL), maybe say the below so it's clear that we ignored the variable and moved on with the default value. `"Ignoring invalid value " << value.get() << " for LIBPROCESS_THREAD_COUNT";` - Jiang Yan Xu On Feb. 3, 2016, 4:40 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43149/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 4:40 p.m.) > > > Review request for mesos, Benjamin Hindman and Jiang Yan Xu. > > > Bugs: MESOS-4592 > https://issues.apache.org/jira/browse/MESOS-4592 > > > Repository: mesos > > > Description > ------- > > Check the LIBPROCESS_THREAD_COUNT environment variable to determine > the number of threads in the libprocess thread pool. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 65a247a5bc7cf0bd6f23f6fc5c349ecce60f5ec0 > > Diff: https://reviews.apache.org/r/43149/diff/ > > > Testing > ------- > > make check on OS X. Running in production for many months. > > > Thanks, > > James Peach > >
