> On Feb. 6, 2016, 2:26 p.m., Klaus Ma wrote: > > src/slave/http.cpp, line 402 > > <https://reviews.apache.org/r/43267/diff/1/?file=1236707#file1236707line402> > > > > For GUI developer, it's better to export more info when it's > > recovering, e.g. build_time, build_date. So I'd like to export agent state > > in `/state`.
I would rather we tease out static information into separate endpoints. For example, version info (including build_time, build_date, git_sha etc) is already exposed in /version endpoint. Having partial information in an endpoint is more confusing. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43267/#review118143 ----------------------------------------------------------- On Feb. 5, 2016, 10:46 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43267/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 10:46 p.m.) > > > Review request for mesos, Anand Mazumdar and Ben Mahler. > > > Bugs: MESOS-4066 > https://issues.apache.org/jira/browse/MESOS-4066 > > > Repository: mesos > > > Description > ------- > > This will help operators hitting the /state endpoint by not returning > incomplete > data when slave is still recoverying. > > > Diffs > ----- > > src/slave/http.cpp 9167030e77efc7e1d0dc0c6bd800d20ba9c55e3c > src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 > > Diff: https://reviews.apache.org/r/43267/diff/ > > > Testing > ------- > > make -j3 check GTEST_FILTER="*StateEndpointUnavailableDuringRecovery*" > > ./bin/mesos-tests.sh > --gtest_filter="*StateEndpointUnavailableDuringRecovery*" --gtest_repeat=1000 > --gtest_break_on_failure > > ./bin/mesos-tests.sh > > > Thanks, > > Vinod Kone > >
