> On Feb. 10, 2016, 11:50 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [43407, 43409, 43410] > > > > Failed command: ./support/apply-review.sh -n -r 43410 > > > > Error: > > 2016-02-10 11:49:59 URL:https://reviews.apache.org/r/43410/diff/raw/ > > [8010/8010] -> "43410.patch" [1] > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/dynamiclibrary.hpp:1: > > A license header should appear on the file's first line starting with > > '// Licensed'.: /** > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/dynamiclibrary.hpp:1: > > A license header should appear on the file's first line starting with > > '// Licensed'.: /** > > Total errors found: 2 > > Checking 3 files > > > > Full log: https://builds.apache.org/job/mesos-reviewbot/11361/console
Ah, sorry, this patch is extremely old, and hhas been resurrected. I'll fix it. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review118629 ----------------------------------------------------------- On Feb. 10, 2016, 6:47 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43411/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 6:47 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4496 > https://issues.apache.org/jira/browse/MESOS-4496 > > > Repository: mesos > > > Description > ------- > > Windows: Added dynamic library loading tests to build. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > 3c65d0422dc6e198180d53d1c9e6cb2839137434 > 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp > 27626ae28db090f1a002239ff5c674b82e8fc9a8 > > Diff: https://reviews.apache.org/r/43411/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
