----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43456/#review118768 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 281) <https://reviews.apache.org/r/43456/#comment180075> Please add comments in 'ContainerConfig' stating that 'rootfs' and 'docker' is for the executor in custom executor case, and is for the task in command task case. - Jie Yu On Feb. 10, 2016, 11:44 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43456/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 11:44 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Prevented linux fs isolator mounting rootfs for command executor. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > b9615becc87e6c69c5c56b6ae76ccae180c26917 > > Diff: https://reviews.apache.org/r/43456/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
