----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43588/#review119255 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 2390) <https://reviews.apache.org/r/43588/#comment180548> s/we/the allocator will src/tests/hierarchical_allocator_tests.cpp (line 2391) <https://reviews.apache.org/r/43588/#comment180554> s/RecoverPercentage/RecoverPercentageWithQuota? How about move this above `DeactivateAndReactivateFramework` to make sure group all `Quota` related tests? src/tests/hierarchical_allocator_tests.cpp (line 2434) <https://reviews.apache.org/r/43588/#comment180549> How about s/Test that the allocator still pauses./Wait for all `addSlave` messages to be dispatched and processed completely? src/tests/hierarchical_allocator_tests.cpp (line 2457) <https://reviews.apache.org/r/43588/#comment180550> s/A we/The framework src/tests/hierarchical_allocator_tests.cpp (line 2474) <https://reviews.apache.org/r/43588/#comment180551> s/we/the framework src/tests/hierarchical_allocator_tests.cpp (line 2482) <https://reviews.apache.org/r/43588/#comment180552> s/the the/the src/tests/hierarchical_allocator_tests.cpp (line 2483) <https://reviews.apache.org/r/43588/#comment180555> s/RecoverTimeout/RecoverTimeoutWithQuota? How about move this above `DeactivateAndReactivateFramework` to make sure group all `Quota` related tests? src/tests/hierarchical_allocator_tests.cpp (line 2524) <https://reviews.apache.org/r/43588/#comment180553> How about s/Test that the allocator still pauses./Wait for all `addSlave` messages to be dispatched and processed completely? - Guangya Liu On 二月 15, 2016, 9:23 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43588/ > ----------------------------------------------------------- > > (Updated 二月 15, 2016, 9:23 p.m.) > > > Review request for mesos, Alexander Rukletsov and Klaus Ma. > > > Bugs: MESOS-3986 > https://issues.apache.org/jira/browse/MESOS-3986 > > > Repository: mesos > > > Description > ------- > > Added allocator recovery tests in presence of quota. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 0acfc098750ff8ff9505207b983a34c1ccf3ad06 > > Diff: https://reviews.apache.org/r/43588/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
